[3.02rc regression] output/codeview: don't panic when there is not code section#221
Open
kasper93 wants to merge 1 commit intonetwide-assembler:masterfrom
Open
[3.02rc regression] output/codeview: don't panic when there is not code section#221kasper93 wants to merge 1 commit intonetwide-assembler:masterfrom
kasper93 wants to merge 1 commit intonetwide-assembler:masterfrom
Conversation
Simply skip the tables that require code section and source information. Fixes: netwide-assembler#216 Fixes: netwide-assembler#178 (comment) Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
kasper93
force-pushed
the
fix-cv-empty-code
branch
from
79a1e21 to
9164a44
Compare
kasper93
changed the title
BtbN
pushed a commit
to FFmpeg/FFmpeg
that referenced
this pull request
Mar 30, 2026
The use of code section (.text) was forced by the unreleased NASM 3.02rc3 which made the issue worse, but preventing assambling anything without code section, including when only data was present. This works fine for the most part, but using code (.text) section with IMAGE_COMDAT_SELECT_ANY causes issues with lib.exe after stripping such object: fatal error LNK1143: invalid or corrupt file: no symbol for COMDAT section 0x2 Esentially it makes our workaround not work in all cases, and while string could be disabled like it already is for MSVC/ICL builds, it used to work so let's preserve that state. This make it not compatible with NASM 3.02rc3 when CV debug info is generated, but hopefully the upstream fix will be merged before release, to avoid this regression: netwide-assembler/nasm#221 Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
perise
pushed a commit
to perise/FFmpeg
that referenced
this pull request
Mar 31, 2026
The use of code section (.text) was forced by the unreleased NASM 3.02rc3 which made the issue worse, but preventing assambling anything without code section, including when only data was present. This works fine for the most part, but using code (.text) section with IMAGE_COMDAT_SELECT_ANY causes issues with lib.exe after stripping such object: fatal error LNK1143: invalid or corrupt file: no symbol for COMDAT section 0x2 Esentially it makes our workaround not work in all cases, and while string could be disabled like it already is for MSVC/ICL builds, it used to work so let's preserve that state. This make it not compatible with NASM 3.02rc3 when CV debug info is generated, but hopefully the upstream fix will be merged before release, to avoid this regression: netwide-assembler/nasm#221 Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
richardpl
pushed a commit
to librempeg/librempeg
that referenced
this pull request
Mar 31, 2026
The use of code section (.text) was forced by the unreleased NASM 3.02rc3 which made the issue worse, but preventing assambling anything without code section, including when only data was present. This works fine for the most part, but using code (.text) section with IMAGE_COMDAT_SELECT_ANY causes issues with lib.exe after stripping such object: fatal error LNK1143: invalid or corrupt file: no symbol for COMDAT section 0x2 Esentially it makes our workaround not work in all cases, and while string could be disabled like it already is for MSVC/ICL builds, it used to work so let's preserve that state. This make it not compatible with NASM 3.02rc3 when CV debug info is generated, but hopefully the upstream fix will be merged before release, to avoid this regression: netwide-assembler/nasm#221 Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
Member
|
Could you comment on how this would affect or interact with #183 ? I'm not a Codeview expert... |
Author
|
Me neither. I've only focused on patching the panic that we sometimes get when generating debug info. Maybe @SEt-t can comment. But I think at least this PR is a bugfix and relatively safe. |
Contributor
|
This PR looks good to me. It was an unhandled case and still is with my update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply skip the tables that require code section and source information.
Fixes: #216
Fixes: #178 (comment)