Add explicit ES type libs for public typings while keeping ES5 runtime target#500
Open
Copilot wants to merge 7 commits into
Open
Add explicit ES type libs for public typings while keeping ES5 runtime target#500Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/1f8223a6-705f-4fbc-82d0-c90d803bf965 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation errors due to missing ES built-ins
Add explicit ES type libs for public typings while keeping ES5 runtime target
May 14, 2026
Contributor
|
@copilot This is only addressing the local test resources and not the actual reported issue. |
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/f6321dc0-0a3d-49a0-941c-47f6a22f2a53 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/f6321dc0-0a3d-49a0-941c-47f6a22f2a53 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Contributor
Author
Updated the fix to target Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
nev21
approved these changes
May 14, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates package-level TypeScript configuration and documentation so public typings can reference newer built-in TypeScript definitions while keeping the emitted runtime target at ES5.
Changes:
- Adds explicit
es2021anddomlibs tolib/tsconfig.json. - Documents consumer
tsconfig.jsonlib requirements in the README. - Adds the fix to the unreleased changelist.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
README.md |
Adds guidance for consumers compiling with ES5-only TypeScript libs. |
lib/tsconfig.json |
Adds explicit TypeScript libs while preserving target: "es5". |
CHANGELIST.md |
Records the package tsconfig/documentation fix under Unreleased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 27 27
Lines 1439 1439
Branches 339 339
=======================================
Hits 1404 1404
Misses 35 35 🚀 New features to boost your workflow:
|
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/aa1009c1-0568-4f76-b2a9-d8befbd8c165 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/3a8e6886-d1c0-44a5-926f-c707599b2b50 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Comment on lines
+4
to
+9
| "lib": [ | ||
| "dom", | ||
| "es2015.promise", | ||
| "es2015.iterable", | ||
| "es2018.asynciterable" | ||
| ], |
Contributor
|
@copilot nevware21/ts-utils#558 has an additional script to populate the api-generated generated *.d.ts should this have the same |
Contributor
Author
I don’t think this PR needs that. This repo already runs API Extractor via |
Contributor
@copilot that is not correct! This project does have a docsgen script that is run which uses api-generator |
Contributor
Author
You’re right — my previous reply was incorrect about that part. This repo does use API Extractor via |
Contributor
@copilot But if we don't add it to the generated *.d.ts, then we are not fixing the isssue right? |
Agent-Logs-Url: https://github.com/nevware21/ts-async/sessions/f4563d82-e957-45c0-ab04-4f4f5c04f7f7 Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Contributor
Author
Right — to fully fix it, the change needs to cover the build path that feeds the generated typings. I updated Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.d.tsartifacts are produced in this repo and whether this fix must update committed generated outputnpm run lint,npm run build,npm test)