Skip to content

[stable8] fix(NcAppNavigation): also emit navigation-toggled on mobile change#8354

Open
skjnldsv wants to merge 1 commit intostable8from
fix/ncappnav-emit-mobile-stable8
Open

[stable8] fix(NcAppNavigation): also emit navigation-toggled on mobile change#8354
skjnldsv wants to merge 1 commit intostable8from
fix/ncappnav-emit-mobile-stable8

Conversation

@skjnldsv
Copy link
Copy Markdown
Contributor

Backport of #8353

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the 8.37.0 milestone Mar 25, 2026
@skjnldsv skjnldsv requested review from ShGKme and susnux March 25, 2026 08:54
@skjnldsv skjnldsv self-assigned this Mar 25, 2026
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels Mar 25, 2026
@skjnldsv skjnldsv changed the title fix(NcAppNavigation): also emit navigation-toggled on mobile change [stable8] fix(NcAppNavigation): also emit navigation-toggled on mobile change Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
βœ… Project coverage is 45.85%. Comparing base (f57b50c) to head (9217d37).

Files with missing lines Patch % Lines
src/components/NcAppNavigation/NcAppNavigation.vue 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           stable8    #8354   +/-   ##
========================================
  Coverage    45.85%   45.85%           
========================================
  Files          194      194           
  Lines         4892     4892           
  Branches      1262     1200   -62     
========================================
  Hits          2243     2243           
- Misses        2561     2563    +2     
+ Partials        88       86    -2     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Antreesy Antreesy modified the milestones: 8.37.0, 8.38.0 Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: app-navigation Related to the app-navigation component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants