[stable8] feat(referencePicker): introduce getReferenceWithPicker()#8609
Closed
backportbot[bot] wants to merge 6 commits into
Closed
[stable8] feat(referencePicker): introduce getReferenceWithPicker()#8609backportbot[bot] wants to merge 6 commits into
backportbot[bot] wants to merge 6 commits into
Conversation
Required for Text and Collectives to pass the link title from the picker (e.g. Collectives PagePicker.vue) to the consumer (menubar in Text). Signed-off-by: Jonas <jonas@freesources.org>
- In NcCustomPickerElement we cannot control the submitted type, so let's add the type check there as well. - NcSearch is exported publically and used by apps, so changing its return type would introduce a backwards-incompatibility. - NcProviderList, NcRawLinkInput and NcCustomPickerElement are not publically exposed, so we can change the emitted type there. Signed-off-by: Jonas <jonas@freesources.org>
…adata Required to keep forward-compatibility with consumers of `getLinkWithPicker()`. Signed-off-by: Jonas <jonas@freesources.org>
…ruthy Signed-off-by: Jonas <jonas@freesources.org>
…cker Signed-off-by: Jonas <jonas@freesources.org>
…`pick` chore(NcReferencePicker): rename new event from `submitReference` to `pick` Signed-off-by: Jonas <jonas@freesources.org> [skip ci]
backportbot
Bot
added
enhancement
Contributor
|
I'll close the backport for now, as I don't think it's worth to backport this feature to the vue2 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8532
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.