feat: Add animation effect for navigation entries#8685
Draft
jancborchardt wants to merge 1 commit into
Draft
Conversation
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8685 +/- ##
==========================================
- Coverage 54.06% 52.97% -1.10%
==========================================
Files 106 106
Lines 3479 3549 +70
Branches 1008 1022 +14
==========================================
- Hits 1881 1880 -1
- Misses 1354 1413 +59
- Partials 244 256 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I do not see anything in the "after" screencast that requires JS changes, that should be possible with pure CSS so no heavy mutation observer is required, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ClaudeCode:claude-opus-4-8
☑️ Resolves
It would be nice to have an animation of the hover feedback highlight of the NcAppNavigation. This makes it feel nicer and smoother, like you are actually interacting with something.
This is a prototype to see how that could look like. Has been tested in the styleguide.
@susnux @ShGKme please check if this would this be good as a base, or should take a different approach.
nextcloud/server#61621 adds global handling for the animation-quick and animation-slow variables to be zeroed under prefers-reduced-motion.
🖼️ Screenshots
🏚️ Before
Screencast.From.2026-06-27.01-40-20.webm
🏡 After
Screencast.From.2026-06-27.01-34-40.webm
🏁 Checklist
stable8for maintained Vue 2 version or not applicable