fix(dev): use kind container's gateway IP instead of NC's proxy IP#98
Open
fix(dev): use kind container's gateway IP instead of NC's proxy IP#98
Conversation
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
This skips the addition of master_default (NC's network) to the kind container and uses the host network for pod -> NC communication. All other communication takes place in host so it would be consistent, and make development easier. Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Contributor
Author
|
not completely sure if they make sense in all other setups but might make development easier. |
Contributor
oleksandr-nc
left a comment
oleksandr-nc
left a comment
There was a problem hiding this comment.
Direction looks good!
A few notes:
- Do the
NC_DOCKER_NETWORK="master_default"in the config block is now unused? - Is
KIND_NODE="${KIND_CLUSTER}-control-plane"defined but the new docker inspectcall hardcodesnc-exapps-control-plane? Should we use"$KIND_NODE"so the two stay in sync if someone changesKIND_CLUSTER` ? - The failure branch still prints
WARNING: Could not detect proxy IP.- should we change that toCould not detect kind gateway IP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.