fix: connectivity service by alperozturk96 · Pull Request #16232 · nextcloud/android

alperozturk96 · 2026-01-02T05:59:26Z

Tests written, or not not needed

Fixes: #14681

Deduplicates isNetworkAndServerAvailable logic

Implements ConnectivityManager.NetworkCallback for better network state listening

Removes deprecated logics

Adds better documentation

Adds exception handling for http call to prevent temporary issues thus we don't inform user with incorrect availability state

Uses for metered detection NET_CAPABILITY_NOT_METERED instead of NET_CAPABILITY_NOT_RESTRICTED

Removes network change receiver uses listener for much better reaction to network change

Converts to Kotlin

TheCrowned · 2026-02-11T18:07:16Z

I gave this build a try - same error for me (both on upload, and on file listing).
The screenshot clearly shows network is available, both as WiFi and as data.
If it can help troubleshooting, upload works when I turn off WiFi and only leave data.

alperozturk96 · 2026-04-07T11:21:29Z

@TheCrowned Hello. Thank you for the feedback. I updated the PR. Could you please check via latest APK file once its generated?

github-actions · 2026-04-07T11:27:50Z

APK file: https://github.com/nextcloud/android/actions/runs/24078742104/artifacts/6304625309
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

github-actions · 2026-04-08T10:20:02Z

APK file: https://github.com/nextcloud/android/actions/runs/24130016101/artifacts/6325219637
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

TheCrowned · 2026-04-08T14:46:03Z

Still no, I'm sorry. WiFi is on, data is off (and in that condition I'm writing this message), and the app reports no connectivity when trying to uplaod files via the Share button in gallery. Also, the app allows to navigate through nextcloud directories and doesn't say "no connectivity", but shows all dirs I had not previously opened as empty.

github-actions · 2026-04-08T14:48:08Z

APK file: https://github.com/nextcloud/android/actions/runs/24140818844/artifacts/6330035040
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

# Conflicts: # app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

…vice.java Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # gradle/libs.versions.toml

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

alperozturk96 · 2026-05-11T13:59:17Z

@TheCrowned Could you explain your setup I cannot reproduce this issue?

Is it local Nextcloud instance?
VPN on or off?

github-actions · 2026-05-11T14:13:26Z

APK file: https://github.com/nextcloud/android/actions/runs/25674377280/artifacts/6920775898
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

github-actions · 2026-05-12T06:38:51Z

Codacy

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	67	67
Dodgy code	216	215
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	34	34
Performance	42	42
Security	16	16
Total	420	419

github-actions · 2026-05-12T06:39:25Z

APK file: https://github.com/nextcloud/android/actions/runs/25717704400/artifacts/6937331531
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

github-actions · 2026-05-12T06:40:56Z

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

github-actions · 2026-05-12T06:44:17Z

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16232-Unit-test-06-39

This was referenced Jan 2, 2026

fix: connectivity service impl #15820

Closed

Upload Failure with "No Internet Connection" Message After Upgrading to Version 3.31.0 on Android App #14681

Open

Missing auto upload files #15822

Open

alperozturk96 force-pushed the fix/connectivity-serv branch from deba220 to c424058 Compare January 27, 2026 10:30

nextcloud deleted a comment from github-actions Bot Jan 27, 2026

alperozturk96 added the 3. to review label Jan 27, 2026

alperozturk96 requested a review from ZetaTom January 27, 2026 10:56

alperozturk96 force-pushed the fix/connectivity-serv branch from 0261ff4 to f2a1b3a Compare February 10, 2026 07:23

This comment was marked as resolved.

Sign in to view

alperozturk96 force-pushed the fix/connectivity-serv branch from 5b5560b to 291868d Compare February 11, 2026 07:11

alperozturk96 force-pushed the fix/connectivity-serv branch from 4f091ab to 7b9830e Compare March 31, 2026 10:50

alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 31, 2026

nextcloud deleted a comment from github-actions Bot Mar 31, 2026

alperozturk96 requested review from AndyScherzinger, mahibi and tobiasKaminsky March 31, 2026 12:29

nextcloud deleted a comment from github-actions Bot Mar 31, 2026

alperozturk96 removed request for AndyScherzinger and mahibi March 31, 2026 14:02

alperozturk96 force-pushed the fix/connectivity-serv branch from 7d56e29 to 4d47cb8 Compare April 7, 2026 11:21

nextcloud deleted a comment from github-actions Bot Apr 7, 2026

AndyScherzinger approved these changes Apr 7, 2026

View reviewed changes

alperozturk96 force-pushed the fix/connectivity-serv branch 2 times, most recently from 2181611 to 1fb36f6 Compare April 8, 2026 09:59

alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Apr 8, 2026

alperozturk96 force-pushed the fix/connectivity-serv branch from 375d7aa to 71b5321 Compare April 8, 2026 14:28

alperozturk96 and others added 19 commits May 11, 2026 15:49

fix: connectivity service impl

eccda68

# Conflicts: # app/src/main/java/com/nextcloud/client/network/ConnectivityServiceImpl.java

fix: connection service impl

a7c80f7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix: connection service tests

abec849

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add wifi and metered check

5fd0592

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add logs

234dce2

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix tests

74a59c6

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fixes

b443696

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Update app/src/main/java/com/nextcloud/client/network/ConnectivitySer…

edac9bc

…vice.java Co-authored-by: Tom <70907959+ZetaTom@users.noreply.github.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>

fix check

1a24b29

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Rename .java to .kt

b8f0c4a

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

convert to kt

2827e15

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fix walled logic

cff3200

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fix isNetworkAndServerAvailable logic

76f3fc3

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fix network change listener

c27f24b

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

wip

11cf495

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

fix tests

e8ea1fe

Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # gradle/libs.versions.toml

cache connectivity per account and address

84dbdd3

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

cache connectivity per account and address

e5c19e8

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

wip

bfe2f88

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

alperozturk96 force-pushed the fix/connectivity-serv branch from 71cfd4c to bfe2f88 Compare May 11, 2026 13:51

wip

6172939

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Uh oh!

Conversation

alperozturk96 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes: #14681

Uh oh!

This comment was marked as resolved.

Uh oh!

TheCrowned commented Feb 11, 2026

Uh oh!

alperozturk96 commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

TheCrowned commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

alperozturk96 commented May 11, 2026

Uh oh!

github-actions Bot commented May 11, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Codacy

SpotBugs

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alperozturk96 commented Jan 2, 2026 •

edited

Loading