Avoid duplicated "New" wording for direct editing creator labels#17355
Open
ChristianTannheimer wants to merge 3 commits into
Open
Avoid duplicated "New" wording for direct editing creator labels#17355ChristianTannheimer wants to merge 3 commits into
ChristianTannheimer wants to merge 3 commits into
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
…34.1.0-rc1 chore: version bump 34.1.0 RC1
Signed-off-by: Christian Tannheimer <chtannheimer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17354
Problem
ONLYOFFICE-based connectors provide full phrases as Direct Editing creator
names ("Neues Dokument" / "New document"). Prefixing the localized "New"
produces duplicated wording like "Neu Neues Dokument" / "New New document".
Solution
Only apply the prefix when the creator name does not already start with the
localized "New" (case-insensitive); otherwise use the server-provided name
as-is. Entries like "Neu Textdokument" / "Neu Whiteboard" are unaffected.
Note: this is a heuristic — for locales where the inflected "new" doesn't
share the prefix string, behavior simply falls back to the current one, so
there is no regression.
Testing
Built
versionDevDebugfromrc-34.1.0-01+ this change, tested on aSamsung Galaxy S25+ against Nextcloud 34.0.1 with the EuroOffice connector
11.0.1 and the official ONLYOFFICE connector 10.1.2.
before
after
