Skip to content

feat(governance): show color dot in retention and legal hold multi-select#17358

Merged
alperozturk96 merged 1 commit into
masterfrom
governanceDots
Jul 21, 2026
Merged

feat(governance): show color dot in retention and legal hold multi-select#17358
alperozturk96 merged 1 commit into
masterfrom
governanceDots

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Jul 21, 2026

Copy link
Copy Markdown
Member

Add colored dot indicator to both the multi-select dialog items and the label text field for file retention and legal hold, consistent with how sensitivity labels display their color.

Assisted-by: ClaudeCode:claude-sonnet-4-6

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@tobiasKaminsky

tobiasKaminsky commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

/backport to stable-34.1.x

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29803443537/artifacts/8484692425
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky @alperozturk96
feat(governance): show color dot in retention and legal hold multi-se…
4b2c74f 
…lect

Add colored dot indicator to both the multi-select dialog items and the
label text field for file retention and legal hold, consistent with how
sensitivity labels display their color.

Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
alperozturk96
alperozturk96 approved these changes Jul 21, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@alperozturk96
alperozturk96 merged commit 9cd9245 into master Jul 21, 2026
18 of 22 checks passed
@alperozturk96
alperozturk96 deleted the governanceDots branch July 21, 2026 11:52
@backportbot backportbot Bot mentioned this pull request Jul 21, 2026
Merged
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total399399

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29827557559/artifacts/8494134189
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17358-IT-master-14-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

Assignees

No one assigned

Labels

3. to review AI assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasKaminsky @alperozturk96