Skip to content

feat: Reusable duration selector#7560

Open
SebastianKrupinski wants to merge 1 commit intomainfrom
feat/meeting-proposal-duration
Open

feat: Reusable duration selector#7560
SebastianKrupinski wants to merge 1 commit intomainfrom
feat/meeting-proposal-duration

Conversation

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski commented Oct 10, 2025 •
edited
Loading

Summary

  • Added reusable duration selector with predefined duration and custom duration, supports minute and iso8601 duration format input and output

Predefined options
image

Custom options
image

@SebastianKrupinski SebastianKrupinski self-assigned this Oct 10, 2025
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Oct 10, 2025
@SebastianKrupinski
Copy link
Copy Markdown
Contributor Author

SebastianKrupinski commented Oct 10, 2025 •
edited
Loading

TODO: Fix visual glitch with NcSelect

Done

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch 3 times, most recently from 92276c6 to 6ce17cb Compare October 10, 2025 22:36
@ChristophWurst
Copy link
Copy Markdown
Member

ChristophWurst commented Nov 4, 2025

TODO: Fix visual glitch with NcSelect

Is that still to do?

ChristophWurst
ChristophWurst previously requested changes Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early feedback

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch from 8e453bd to 022af9a Compare November 4, 2025 19:51
@SebastianKrupinski
Copy link
Copy Markdown
Contributor Author

SebastianKrupinski commented Nov 4, 2025

TODO: Fix visual glitch with NcSelect

Is that still to do?

Nope, this is dealt with

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch from 022af9a to 3eddeea Compare November 4, 2025 19:53
@ChristophWurst
Copy link
Copy Markdown
Member

ChristophWurst commented Nov 5, 2025

Nope, this is dealt with

Then please mark it as such

@SebastianKrupinski
Copy link
Copy Markdown
Contributor Author

SebastianKrupinski commented Dec 1, 2025

@ChristophWurst ^^ can we remove the block now

@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch 2 times, most recently from b234e48 to d118212 Compare March 30, 2026 16:45
@SebastianKrupinski
feat: Reusable duration selector
b85af32 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/meeting-proposal-duration branch from d118212 to b85af32 Compare March 30, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov GVodyanov approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianKrupinski @ChristophWurst @GVodyanov