Skip to content

[stable5.5] Fix npm audit#7563

Merged
SebastianKrupinski merged 2 commits intostable5.5from
automated/noid/stable5.5-fix-npm-audit
Apr 13, 2026
Merged

[stable5.5] Fix npm audit#7563
SebastianKrupinski merged 2 commits intostable5.5from
automated/noid/stable5.5-fix-npm-audit

Conversation

@nextcloud-command
Copy link
Copy Markdown
Contributor

@nextcloud-command nextcloud-command commented Oct 12, 2025

Audit report

This audit fix resolves 2 of the total 51 vulnerabilities found in your project.

Updated dependencies

Fixed vulnerabilities

@nextcloud/webpack-vue-config #

@playwright/test #

  • Caused by vulnerable dependency:
  • Affected versions: 0.9.7 - 0.1112.0-alpha2 || 1.38.0-alpha-1692262648000 - 1.55.1-beta-1758616458000
  • Package usage:
    • node_modules/@playwright/test

@nextcloud-command nextcloud-command added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Oct 12, 2025
@nextcloud-command nextcloud-command added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Oct 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 13c248f to 12deab3 Compare October 26, 2025 03:19
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 12deab3 to 9be6504 Compare November 2, 2025 03:42
@SebastianKrupinski SebastianKrupinski force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 9be6504 to d9ca0ae Compare November 8, 2025 13:00
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from d9ca0ae to 48ff605 Compare November 9, 2025 03:24
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 11512ed to fc9f098 Compare November 23, 2025 03:32
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from fc9f098 to 35adac4 Compare November 30, 2025 03:34
Copy link
Copy Markdown
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest does what Jest does best: Not supporting ESM dependencies ...

    SyntaxError: Cannot use import statement outside a module

      3 |  * SPDX-License-Identifier: AGPL-3.0-or-later
      4 |  */
    > 5 | import DavClient from '@nextcloud/cdav-library'
        | ^

Solutions: Add dependencies (and their sub-dependencies) to the transform-exclude-except list in a painful trial-and-error process or migrate to Vitest ...

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

Hi @st3iny

Thanks for the assist! I was thinking of migrating it to vitest actually as this is becoming a constant problem.

@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 8d2d4ca to c1e7e38 Compare December 14, 2025 03:38
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 6a989a9 to d9d6732 Compare December 28, 2025 03:31
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from d9d6732 to fea724c Compare January 4, 2026 03:35
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 663fde6 to b82ecf8 Compare January 18, 2026 03:44
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from b82ecf8 to 78dda59 Compare January 25, 2026 03:51
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 78dda59 to 677591c Compare February 1, 2026 04:15
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 9d02ccc to 39a382c Compare February 15, 2026 03:52
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 39a382c to f934031 Compare February 22, 2026 03:48
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 9452c20 to d9dcf0e Compare March 8, 2026 03:35
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from d9dcf0e to 7d01b57 Compare March 15, 2026 03:53
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 7d01b57 to 324e6e0 Compare March 22, 2026 03:56
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch 2 times, most recently from 15afe01 to 9807d06 Compare April 5, 2026 03:54
@nextcloud-command nextcloud-command force-pushed the automated/noid/stable5.5-fix-npm-audit branch from 9807d06 to d2393b2 Compare April 12, 2026 04:03
Signed-off-by: GitHub <noreply@github.com>
@SebastianKrupinski SebastianKrupinski force-pushed the automated/noid/stable5.5-fix-npm-audit branch from d2393b2 to af84a1f Compare April 13, 2026 15:23
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski
Copy link
Copy Markdown
Contributor

SebastianKrupinski commented Apr 13, 2026

Fixed the tests, with a additional commit.

Issue was @nextcloud/paths is ESM only now and @nextcloud/dialogs was loading it a CommonJS. The easiest fix was to mock a stub for the basename function of paths. Tests now pass without converting everything to Vitest

@SebastianKrupinski SebastianKrupinski merged commit d412313 into stable5.5 Apr 13, 2026
43 of 45 checks passed
@SebastianKrupinski SebastianKrupinski deleted the automated/noid/stable5.5-fix-npm-audit branch April 13, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants