perf(appointments): reduce bundle size bloat by @nextcloud/vue

[ChristophWurst]

Details

From https://stable8--nextcloud-vue-components.netlify.app/

Import from a single root is available as well. Use with caution: this might lead to slower build time and larger bundles in some cases.

The appointments scripts are small and standalone. They use a few nextcloud/vue components. On main we include the full nextcloud/vue. It will not be tree shaken.

Comparison

Before

Entrypoints:
  main (5.64 MiB)
      calendar-main.js?v=a7305326cd103dfb1881
  contacts-menu (333 KiB)
      calendar-contacts-menu.js?v=9003c166b073eb6859e5
  appointments-booking (3.48 MiB)
      calendar-appointments-booking.js?v=30b2a188baa1c9f0c8e3
  appointments-confirmation (403 KiB)
      calendar-appointments-confirmation.js?v=09c94c3f873574961d8d
  appointments-conflict (403 KiB)
      calendar-appointments-conflict.js?v=5b98e8588590912beb50
  appointments-overview (3.17 MiB)
      calendar-appointments-overview.js?v=601d743edc8ea917e84b
  proposal-public (1.99 MiB)
      calendar-proposal-public.js?v=6bae3689fb176fc337c9

After

Entrypoints:
  main (5.64 MiB)
      calendar-main.js?v=c69cd9e13409ea3714ea
  contacts-menu (333 KiB)
      calendar-contacts-menu.js?v=7ef629f700fce7391355
  appointments-booking (1.35 MiB)
      calendar-appointments-booking.js?v=a8191000967f91886fdf
  appointments-confirmation (403 KiB)
      calendar-appointments-confirmation.js?v=09c94c3f873574961d8d
  appointments-conflict (403 KiB)
      calendar-appointments-conflict.js?v=5b98e8588590912beb50
  appointments-overview (3.17 MiB)
      calendar-appointments-overview.js?v=601d743edc8ea917e84b
  proposal-public (1.99 MiB)
      calendar-proposal-public.js?v=22fba3be8899be9df924

[codecov]

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/views/Appointments/Booking.vue	0.00%	6 Missing ⚠️
src/components/Appointments/AppointmentDetails.vue	0.00%	4 Missing ⚠️
...ts/Appointments/AppointmentBookingConfirmation.vue	0.00%	1 Missing ⚠️
src/components/Appointments/AppointmentSlot.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[tcitworld]

Needs a lint as well

[tcitworld]

It's used as EmptyContent, not NcEmptyContent

[ChristophWurst]

After a local rebase to main I no longer see the original speedup. The bundle is now always big.