feat(importing): show all writable calendars in picker#7876
feat(importing): show all writable calendars in picker#7876odzhychko wants to merge 1 commit intonextcloud:mainfrom
Conversation
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
ChristophWurst
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
odzhychko
force-pushed
the
2572
branch
2 times, most recently
from
fbd478e to
a28bec5
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
This code is now rebased and works with the recent update to Vue 3. |
| .import-modal-file-item { | ||
| display: flex; | ||
| padding-top: 10px; | ||
| margin-top: 10px; |
There was a problem hiding this comment.
Hey! Thanks a lot for the PR!
Could you please use css variables for these changes?
https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html
| margin-top: 10px; | |
| margin-top: calc(var(--default-grid-baseline) * 2); |
There was a problem hiding this comment.
Done
Cool that the UI gets more consistent bit by bit 😄
Mark unsupported calendars as non-selectable. Previously they were fully hidden. Show a message about why some calendars are not selectable. Also show calendars that do not support events (and only support tasks and/or journal entries). Previously, calendars that did not support events were hidden altogether. Resolves: nextcloud#2572 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
3 participants
Mark unsupported calendars as non-selectable.
Previously they were fully hidden.
Show a message about why some calendars are not selectable.
Also show calendars that do not support events (and only support tasks and/or journal entries).
Previously, calendars that did not support events were hidden altogether.
Resolves: #2572
Before
After
Test data
SampleIcsFiles.zip
After (previous iterations)
First iteration
Second iteraton (vertical margin 10px)