Feat Proposal email generation send dates converted with user timezone#8128
Closed
taiebot wants to merge 6 commits intonextcloud:mainfrom
Closed
Feat Proposal email generation send dates converted with user timezone#8128taiebot wants to merge 6 commits intonextcloud:mainfrom
taiebot wants to merge 6 commits intonextcloud:mainfrom
Conversation
Signed-off-by: taiebot <dedreuil@yahoo.fr>
Signed-off-by: taiebot <dedreuil@yahoo.fr>
taiebot
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
taiebot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the email sent with the proposed dates are in UTC so there can be a big gap with the proposed times and the user actual times. I had few comments at work.
=> This pr convert the dates to user timezone and put the user timezone at the end.
Tested
With the following proposal
Before PR Times in UTC
After PR Times in user timezone + timezone displayed
