fix(versions): fix duplicate entry for key 'c_p_versions_uniq_idx'#2451
Open
mejo- wants to merge 1 commit into
Open
fix(versions): fix duplicate entry for key 'c_p_versions_uniq_idx'#2451mejo- wants to merge 1 commit into
mejo- wants to merge 1 commit into
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
mejo-
force-pushed
the
fix/versions_duplicate_key_entry
branch
from
cf12b9c to
f6621ec
Compare
Comment on lines
+111
to
+116
| try { | ||
| $this->collectiveVersionMapper->insert($versionEntity); | ||
| } catch (DBException $e) { | ||
| if ($e->getReason() !== DBException::REASON_UNIQUE_CONSTRAINT_VIOLATION) { | ||
| throw $e; | ||
| } |
Collaborator
There was a problem hiding this comment.
I think we could have our own exception for this and throw it from the ->insert() function.
That way we could easily catch it without rethrowing other DBExceptions.
max-nextcloud
approved these changes
Jun 25, 2026
max-nextcloud
left a comment
max-nextcloud
left a comment
Collaborator
There was a problem hiding this comment.
Just one minor comment. Other that that looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A race condition in requests could lead to this error as two requests tried to create version entries for the same fileId + timestamp combination.
Fix the bug by catching these errors and handling them gracefully.
Fixes: #1886
Fixes: #2405
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)