Update related contacts on manager deletion#3077
Open
bkrith wants to merge 1 commit intonextcloud:mainfrom
Open
Update related contacts on manager deletion#3077bkrith wants to merge 1 commit intonextcloud:mainfrom
bkrith wants to merge 1 commit intonextcloud:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
||
| <!-- main contacts details --> | ||
| <ContactDetails :contact-key="selectedContact" :contacts="sortedContacts" /> | ||
| <ContactDetails :contact-key="selectedContact" :sorted-contacts="sortedContacts" :contacts="contacts" /> |
Member
There was a problem hiding this comment.
is this change really necessary for the fix?
Member
|
@bkrith please do the following two things
|
ChristophWurst
added
bug
Member
|
@bkrith friendly 🏓 . Please have a look at the review feedback above when you have time :) |
Member
|
Hi @bkrith ! As @ChristophWurst said, can you take a look at the review feedback above ? Thanks ! |
|
Hello, I hope you are well. In our Nextcloud instance we removed the main administrator and the org chart stopped showing. I was wondering if they will be looking for a solution for this soon? Or if there are some steps I can take to fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3058
Before deletion remove property managersName reference for each related contact.