fix: restore address book navigation in the sidebar#5417
Conversation
pagaille
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
- Add address books section to the left sidebar navigation so users can filter contacts by address book (feature was removed in bd536c0 when settings were moved to a modal dialog) - Fix sharing button never showing due to wrong property name: currentUserPrincipal.principalUrl → currentUserPrincipal.url, causing isSharedWithMe to always be true and hiding the share button Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matthieu <webmail@gaillet.be>
- Fix "Missing required param selectedGroup" error when browsing an address book: ContactsListItem now uses GROUP_ALL_CONTACTS as fallback and selectFirstContactIfNone() early-exits on the addressbook route - New contacts created while an address book is selected are saved into that address book instead of the default one Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matthieu <webmail@gaillet.be>
The sharing functionality already works correctly in the settings modal. The principalUrl property change was not actually needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matthieu <webmail@gaillet.be>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matthieu <webmail@gaillet.be>
pagaille
force-pushed
the
fix/addressbook-navigation-and-sharing
branch
from
9661835 to
4ca235f
Compare
|
@pagaille please point your agent to Claude.md or Agents.md and update or recreate the PR |
Apologizes ! I didn't know and I must admit I was a bit quick on this one, that's my first PR using an AI agent. I'll close it and recreate accurately. |
No worries, thank you for understanding 😊 |
|
Closing to recreate with a clean history and proper commit format per AGENTS.md. |
|
for more context, If I understood your PR correctly from a first glance. |
2 participants
Summary
Address books used to be listed in the left sidebar (via the now-deleted
SettingsSection.vue), allowing users to click on a book to filter contacts. This was lost in bd536c0 when the settings were migrated to a modal dialog — the address books moved into the modal but no navigation equivalent was added, making the "New address book" feature essentially invisible and useless.This PR restores the feature:
RootNavigation.vue), listing all enabled address books with a contact counteraddressbook/:selectedAddressbookto navigate by address bookcontactsListaddressbookroute (selectFirstContactIfNone,ContactsListItem)Test plan
🤖 Generated with Claude Code