l10n: Improve Russian translation + add missing "Select account" key#8124
Open
dkochetkov wants to merge 2 commits into
Open
l10n: Improve Russian translation + add missing "Select account" key#8124dkochetkov wants to merge 2 commits into
dkochetkov wants to merge 2 commits into
Conversation
- Refined existing Russian translations (ru.js / ru.json) based on native speaker feedback - Added missing translation key for "Select account" - Updated SharingTabSidebar.vue to use localised string for NcSelectUsers input-label Resolves: Display of English "Select account" in the sharing sidebar Signed-off-by: Den Kochetkov <d@asknotbad.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Russian localization of the Deck app and fixes a missing translation in the sharing sidebar.
Translation improvements
l10n/ru.jsandl10n/ru.json→ Natural, idiomatic, and context-aware revisions by a native speaker
"Select account"translation key→ Previously, the
NcSelectUserscomponent used its internal English placeholder(no translation applied at all); now fully localized via
:input-label="t('deck', 'Select account')"Implementation
SharingTabSidebar.vueto use localized string::input-label="t('deck', 'Select account')"→ Now displays "Выберите пользователя" instead of default English fallback
Testing
Checklist