ci: restrict scheduled deploy matrix to supported branches#15269
Merged
Conversation
github-actions
Bot
added
the
github_actions
miaulalala
approved these changes
Jul 2, 2026
Contributor
📖 Documentation PreviewNo RST documentation pages changed in this PR. Last updated: Thu, 02 Jul 2026 14:40:46 GMT |
The consolidated deploy matrix iterated every stable* branch on the remote, including long out-of-support ones (stable9..stable29). In a single run this also blows past the 256-jobs-per-run limit and wastes CI on branches that no longer build. - prepare now builds master + only the stable branches within the support window, reusing build/detect-versions.php for the lowest..highest range. - workflow_dispatch gains an optional "branch" input to build & deploy a single branch on demand (empty = master + all supported stables). Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/deploy-supported-branches-only
branch
from
4bbe00f to
a9244d7
Compare
The deploy resolves build-docs.yml from master for every matrix leg, so a hardcoded python-version would build all branches with master's Python. Read the version from the checked-out branch (.python-version) instead, falling back to 3.13 when the file is absent, so each version can pin its own Python even under the shared workflow. requirements.txt only pins packages and cannot carry the interpreter version. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
The redirect step iterated every server/*/ folder on gh-pages, including ancient versions (server/12) whose legacy layout has go.php as a file, so mkdir -p failed. Track the folders applied this run in the apply step and restrict the redirect loop to those, and remove any stale go.php path first. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Merged
Stable branches conf.py derive the display version from GITHUB_BASE_REF / GITHUB_REF, which in the single-run deploy reflect the workflow branch, not the matrix leg. Every stable build was therefore mislabelled as the dev version (e.g. stable32 rendered as "35 / latest"). Expose the built branch via GITHUB_BASE_REF in the build jobs so each stable conf.py resolves correctly; master conf.py is unaffected (it uses DOCS_DISPLAY_VERSION). Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Add a small table to the deploy PR body showing how many files changed per version folder, so reviewers can see at a glance what actually got updated. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Overriding the reserved GITHUB_BASE_REF via job env does not reach the build process (the runner ignores it), so stable builds were still mislabelled. Instead rely on DOCS_DISPLAY_VERSION, which build-html already exports via detect-versions and which the epub job now sets too (PDF is covered by DOCS_RELEASE). Stable branches conf.py must read DOCS_DISPLAY_VERSION for this to take effect (backported separately). Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15266.
The consolidated deploy matrix iterated every
stable*branch incl. long out-of-support ones (stable9–29),Now builds master + supported stables only (via
build/detect-versions.php), and adds abranchworkflow_dispatchinput to build one branch on demand.Test run https://github.com/nextcloud/documentation/actions/runs/28593355214/job/84782298571
AI-assisted (ClaudeCode:claude-opus-4-8).