refactor: remove duplicate computed prop from Ranking#3409
Open
Chartman123 wants to merge 1 commit into
Open
Conversation
Chartman123
added
3. to review
Collaborator
Author
|
/backport to stable5.3 |
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
chore/remove-duplicate-computed
branch
from
5612eef to
8e57ba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes contentValid() from QuestionRanking. It's already defined in QuestionMultipleMixin:
forms/src/mixins/QuestionMultipleMixin.ts
Lines 32 to 34 in 5612eef