fix: Fixed custom script not being loaded on two factor pages#51
Open
ChiaraBm wants to merge 1 commit into
Open
fix: Fixed custom script not being loaded on two factor pages#51ChiaraBm wants to merge 1 commit into
ChiaraBm wants to merge 1 commit into
Conversation
Signed-off-by: ChiaraBm <chiara.bm04@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
i have noticed that custom scrips using this app are not loaded on the two factor pages as request to the controller providing the script gets blocked by the two factor app. In this pull request i just added the annotation which allows the controller being accessible in the two factor state.
Thank you for reading and i hope you will merge it so i no longer need to modify it locally myself 🙏