Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes obsolete networking routers in favor of NextcloudKit and introduces a canonical server address parser to normalize user-provided server URLs (e.g., preventing duplicated /index.php segments).
Changes:
- Added
canonicalServerComponents(from:)and migrated URL building to use it across networking and account setup. - Replaced custom
/status.phprequest logic with NextcloudKit’s server status API. - Removed obsolete
StatusRouter/OCSRouterand related OCS header helper.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| iOCNotes/Views/SettingsView.swift | UI tweak to keep settings title inline. |
| iOCNotes/Store.swift | Uses canonical server components to derive base URL for accounts. |
| iOCNotes.xcodeproj/project.pbxproj | Removes deleted router files from project references/build phases. |
| Utils/UtilityExtensions.swift | Adds canonical server URL parsing helper. |
| Networking/StatusRouter.swift | Deletes obsolete status router code. |
| Networking/ServerStatus.swift | Builds /status.php URL via canonical components (no router). |
| Networking/Router.swift | Builds Notes API base URL via canonical components instead of string concat + asURL(). |
| Networking/OCSRouter.swift | Deletes obsolete OCS router code. |
| Networking/NoteSessionManager.swift | Migrates status fetch to NextcloudKit async API. |
| Networking/HTTPHeader+Extensions.swift | Removes OCS header helper no longer used. |
i2h3
approved these changes
May 21, 2026
Collaborator
i2h3
left a comment
There was a problem hiding this comment.
Formatting could be prettier and more comfortable to read but besides that it looks fine to me. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially fixes:
#185
#171
#161
#146