Skip to content

Fix/use new button component#31241

Merged
vanpertsch merged 1 commit into
masterfrom
fix/use-new-button-component
Feb 22, 2022
Merged

Fix/use new button component#31241
vanpertsch merged 1 commit into
masterfrom
fix/use-new-button-component

Conversation

@vanpertsch
Copy link
Copy Markdown
Contributor

@vanpertsch vanpertsch commented Feb 17, 2022

The default button style changed.

Screenshot 2022-02-17 at 14 09 31

Screenshot 2022-02-17 at 14 04 32

CarlSchwan
CarlSchwan approved these changes Feb 17, 2022
View reviewed changes
Comment thread apps/dav/src/views/Availability.vue Outdated
Comment thread apps/files/src/components/TransferOwnershipDialogue.vue Outdated
@PVince81 PVince81 added the 3. to review Waiting for reviews label Feb 17, 2022
@PVince81 PVince81 added this to the Nextcloud 24 milestone Feb 17, 2022
PVince81
PVince81 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jancborchardt
jancborchardt approved these changes Feb 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

There is some more whitespace on top and bottom, is that from the component – and should that be? @marcoambrosini

@marcoambrosini
Copy link
Copy Markdown
Member

marcoambrosini commented Feb 21, 2022

The whitespace doesn't come from the component @jancborchardt

@tcitworld
Copy link
Copy Markdown
Member

tcitworld commented Feb 21, 2022

@vanpertsch You seem to have added a lot of unrelated commits in this PR. Do you need help with cleaning that?

@vanpertsch
Copy link
Copy Markdown
Contributor Author

vanpertsch commented Feb 21, 2022

@tcitworld that would be amazing. :). (i tried to rebase, solve conflicts. Than i pulled the changes, solved conflicts. ... and am a bit lost and wonder what would be the right way to do it)

@tcitworld tcitworld force-pushed the fix/use-new-button-component branch from c617fb7 to d760143 Compare February 21, 2022 10:48
@tcitworld
Copy link
Copy Markdown
Member

tcitworld commented Feb 21, 2022 •
edited
Loading

/compile amend /

EDIT: Probably haven't got the permission :(

tcitworld
tcitworld reviewed Feb 21, 2022
View reviewed changes
Comment thread apps/dav/src/views/Availability.vue Outdated
Comment thread apps/files/src/components/TransferOwnershipDialogue.vue Outdated
@nextcloud-command nextcloud-command force-pushed the fix/use-new-button-component branch from d760143 to 6424d62 Compare February 21, 2022 12:48
@vanpertsch vanpertsch force-pushed the fix/use-new-button-component branch from 6424d62 to 383245f Compare February 21, 2022 15:34
@skjnldsv skjnldsv requested a review from tcitworld February 21, 2022 15:48
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 21, 2022
@vanpertsch vanpertsch merged commit c4d09af into master Feb 22, 2022
@vanpertsch vanpertsch deleted the fix/use-new-button-component branch February 22, 2022 09:34
@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 22, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Copy Markdown
Member

skjnldsv commented Feb 22, 2022

🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@miaulalala miaulalala Awaiting requested review from miaulalala

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

@vanpertsch vanpertsch

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

7 participants

@vanpertsch @marcoambrosini @tcitworld @skjnldsv @PVince81 @jancborchardt @CarlSchwan