Skip to content

Deprecate our old, internal background job base classes #31317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Feb 22, 2022
Merged

Deprecate our old, internal background job base classes #31317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/private/BackgroundJob/Job.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
use OCP\BackgroundJob\IJobList;
use OCP\ILogger;

/**
* @deprecated internal class, use \OCP\BackgroundJob\Job
*/
abstract class Job implements IJob {
/** @var int */
protected $id;
Expand Down
3 changes: 3 additions & 0 deletions lib/private/BackgroundJob/Legacy/QueuedJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
*/
namespace OC\BackgroundJob\Legacy;

/**
* @deprecated internal class, use \OCP\BackgroundJob\QueuedJob
*/
class QueuedJob extends \OC\BackgroundJob\QueuedJob {
public function run($argument) {
$class = $argument['klass'];
Expand Down
3 changes: 3 additions & 0 deletions lib/private/BackgroundJob/Legacy/RegularJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@

use OCP\AutoloadNotAllowedException;

/**
* @deprecated internal class, use \OCP\BackgroundJob\QueuedJob
*/
class RegularJob extends \OC\BackgroundJob\Job {
public function run($argument) {
try {
Expand Down
2 changes: 2 additions & 0 deletions lib/private/BackgroundJob/QueuedJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
* create a background job that is to be executed once
*
* @package OC\BackgroundJob
*
* @deprecated internal class, use \OCP\BackgroundJob\QueuedJob
*/
abstract class QueuedJob extends Job {
/**
Expand Down
2 changes: 2 additions & 0 deletions lib/private/BackgroundJob/TimedJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
* create a background job that is to be executed at an interval
*
* @package OC\BackgroundJob
*
* @deprecated internal class, use \OCP\BackgroundJob\TimedJob
*/
abstract class TimedJob extends Job {
protected $interval = 0;
Expand Down