fix(core): Throttle lost-password reset form when link is disabled#61615
Open
nfebe wants to merge 1 commit into
Open
fix(core): Throttle lost-password reset form when link is disabled#61615nfebe wants to merge 1 commit into
nfebe wants to merge 1 commit into
Conversation
When password reset links were disabled, the reset form did not rate-limit failed token attempts, leaving that endpoint open to unthrottled token guessing. Failed attempts on the form are now always throttled, consistent with the other reset steps. Signed-off-by: nfebe <fenn25.fn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When password reset links were disabled, the reset form did not rate-limit failed token attempts, leaving that endpoint open to unthrottled token guessing. Failed attempts on the form are now always throttled, consistent with the other reset steps.