Skip to content

fix(core): add server version to frontend chunk file names #65793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szaimen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(core): add server version to frontend chunk file names #65793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions build/frontend/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@
*/

import { createAppConfig } from '@nextcloud/vite-config'
import { readFileSync } from 'node:fs'
import { resolve } from 'node:path'

// Chunks and assets are loaded without the `?v=` cache buster, so the server version is part of their file names
const serverVersion = readFileSync(resolve(import.meta.dirname, '../..', 'version.php'), 'utf-8')
.match(/\$OC_VersionString = '([^']+)';/)![1]
.replaceAll(/[^\w.-]/g, '-')

const modules = {
appstore: {
main: resolve(import.meta.dirname, 'apps/appstore/src', 'main.ts'),
Expand Down Expand Up @@ -167,12 +173,12 @@ export default createAppConfig(Object.fromEntries(viteModuleEntries), {
rollupOptions: {
output: {
entryFileNames: '[name].mjs',
chunkFileNames: '[name]-[hash].chunk.mjs',
chunkFileNames: `[name]-${serverVersion}-[hash].chunk.mjs`,
assetFileNames({ originalFileNames }) {
const apps = originalFileNames.map((name) => name.match(/apps\/([^/]+)\//)?.[1])
.filter(Boolean)
const appId = apps.length === 1 ? apps[0] : 'common'
return `${appId}-[name]-[hash][extname]`
return `${appId}-[name]-${serverVersion}-[hash][extname]`
},
experimentalMinChunkSize: 100 * 1024,
/* // with rolldown-vite:
Expand Down
Loading