fix: Check group allow list based on the display name - #1478
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
Since a few versions ago, we use ICreateNamedGroupBackend to create group on the default database backend. This will use the display name as GID unless the display name is too long and in that case will use a random GID. This random GID is impossible to match with the regex. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a few versions ago, we use ICreateNamedGroupBackend to create group on the default database backend. This will use the display name as GID unless the display name is too long and in that case will use a random GID.
This random GID is impossible to match with the regex.
Fix #1472
Thanks to @OScaleSven for the initial research :)
🤖 AI (if applicable)