Remove duplicate session_pb2 codegen, add ni-apis submodule and dependency on ni.grpcdevice.v1.proto#2176
Open
Remove duplicate session_pb2 codegen, add ni-apis submodule and dependency on ni.grpcdevice.v1.proto#2176
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2176 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 73 73
Lines 19006 19006
=======================================
+ Hits 17077 17078 +1
+ Misses 1929 1928 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
reviewed
Apr 13, 2026
ni-jfitzger
reviewed
Apr 13, 2026
ni-jfitzger
reviewed
Apr 13, 2026
3 tasks
…ady installing through tox.ini files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Replaces the duplicate
session_pb2protobuf codegen in each nimi-python driver modules with a dependency onni.grpcdevice.v1.proto(similar to [ni/nidaqmx-python#859].import from . import session_pb2with absoluteimport session_pb2in_grpc_stub_interpreter.py.makoni.grpcdevice.v1.proto>=1.0.0as part of installers for modules that support grpc.session_pb2.pyandsession_pb2_grpc.pysession.protofilesubmodules: trueto all GitHub Actions checkout steps so CI clones the submoduleList issues fixed by this Pull Request below, if any.
What testing has been done?
ni.grpcdevice.v1.protopackage than importing from locally generatedsession_pb2file as before.