Fix multitude of warnings#305
Merged
Merged
Conversation
Contributor
|
Thank you for contributing! 👋 |
irwand
approved these changes
Jun 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR reduces runtime warnings emitted by ni-python-styleguide by updating the flake8-import-order dependency (and removing the direct setuptools pin that was needed for older flake8-import-order versions), aligning with the goal of resolving the warning noise described in the PR and addressing #226.
Changes:
- Bump
flake8-import-orderto0.19.2and drop the directsetuptoolspin inpyproject.toml. - Regenerate
poetry.lockto reflect the dependency update. - Remove the Renovate rule that previously disabled updates for
flake8-import-order/setuptools. - Adjust the “bare CLI” tests’ success assertions/output checks.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_cli/test_bare.py | Updates assertions for invoking the CLI with no args / --help. |
| pyproject.toml | Updates dependency constraints (notably flake8-import-order) and removes the direct setuptools pin. |
| poetry.lock | Locks flake8-import-order at 0.19.2 and updates the lock metadata accordingly. |
| .github/renovate.json | Removes the rule that disabled Renovate updates for the previously pinned packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bkeryan
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
Currently, running ni-python-styleguide on a code base will print a lot of warnings like
Upgrading to newer flake8-import-order and removing the pin on setuptools resolves this.
This also resolves #226