fix(gemini): handle blob-backed generated images#115
Open
goneflyin wants to merge 1 commit into
Open
Conversation
Author
|
In all candor, totally used Pi to generate this PR without looking closely at the surf code... not my milieu. Pretty sure it works and is accurate, but feel free to yell at me if not and I'll revise as needed. Thanks for the tool! |
3f83839 to
3f16d99
Compare
3f16d99 to
7e31000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Gemini image generation can complete successfully in the browser but
surf gemini --generate-imagekeeps polling until timeout because the UI now renders the generated image asblob:https://gemini.google.com/.... The existing poller only looks forimg[src*="gg-dl"], so image-only responses have no success condition.Test plan
npm test -- --run test/unit/gemini-client.test.tsnpm test -- --run test/unit/chatgpt-client.test.ts test/unit/grok-client.test.tsNote:
npm run checkandnpm run lintcurrently fail on main due to unrelated existing TypeScript/Biome config errors.