Skip to content

Commit ac9cdaa

Browse files
Fix some code smells
1 parent 9dd1d11 commit ac9cdaa

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/main/java/engineer/nightowl/sonos/api/resource/BaseResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ <T extends HttpRequestBase> T getStandardRequest(final Class<T> requestType, fin
269269
final T request;
270270
try
271271
{
272-
request = requestType.newInstance();
272+
request = requestType.getDeclaredConstructor().newInstance();
273273
} catch (final Exception e)
274274
{
275275
throw new SonosApiClientException("Unable to create class " + requestType.getSimpleName(), e);

src/test/java/engineer/nightowl/sonos/api/resource/AuthorizeResourceTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package engineer.nightowl.sonos.api.resource;
22

3-
import engineer.nightowl.sonos.api.BaseTest;
3+
import engineer.nightowl.sonos.api.BaseTestSetup;
44
import org.apache.http.NameValuePair;
55
import org.apache.http.client.utils.URLEncodedUtils;
66
import org.junit.Assert;
@@ -12,7 +12,7 @@
1212
import java.util.HashMap;
1313
import java.util.List;
1414

15-
public class AuthorizeResourceTest extends BaseTest
15+
public class AuthorizeResourceTest extends BaseTestSetup
1616
{
1717
private final AuthorizeResource authorizeResource = new AuthorizeResource(apiClient);
1818

@@ -31,7 +31,7 @@ public void testGetAuthorizeCodeWithState() throws URISyntaxException
3131
Assert.assertEquals("https", uri.getScheme());
3232
uri.getQuery();
3333

34-
final List<NameValuePair> params = URLEncodedUtils.parse(uri, StandardCharsets.UTF_8.name());
34+
final List<NameValuePair> params = URLEncodedUtils.parse(uri, StandardCharsets.UTF_8);
3535
final HashMap<String, String> map = new HashMap<>();
3636
params.forEach(p -> map.put(p.getName(), p.getValue()));
3737

0 commit comments

Comments
 (0)