Support nimble2 with various features#212
Merged
Merged
Conversation
…n project_env$known_nClasses
…e nList's getLength and setLength to base class.
Contributor
|
@perrydv I think this has broken |
Contributor
Author
|
@paciorek have you tried rebuilding nimbleModel with the updated nCompiler installed? There is the issue that calls to nClass in nimbleModel will bake in nClass features from nCompiler, so if nCompiler updates, nimbleModel can break for that reason. Eventually we may want many or all nClasses created in a package like nimbleModel to be created in |
Contributor
|
@perrydv thanks; that resolved the problem. You've probably told me about this before but I haven't absorbed it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in features for supporting a new version of nimble with nimbleModel. These include:
project_env.A$B$C) when there were TBD types to be resolved.get_interface_ptrfeature of the generic interface in C++.RuntimeFlatViewandRuntimeFlatViewGroupto support nimble'svalues()keyword.@paciorek I don't think this needs a rebase. OK to merge and then you can rebase your TBB branch (again)?