Repository navigation
fix: unify HTTP factory and migrate tests to official MCP transport - #36
Open
jpsiddharth2008 wants to merge 7 commits into
Open
jpsiddharth2008 wants to merge 7 commits into
jpsiddharth2008 wants to merge 7 commits into
Conversation
Shreyavemana
left a comment
Collaborator
There was a problem hiding this comment.
I tested PR #36 locally.
- The issue verification tests pass (46 passed).
- However, the full test suite fails: four test files fail during collection because of removed modules/functions, and two additional tests fail after excluding them:
test_mcp20_blueprint.py— missingnitrostack.transports.dispatchtest_mcp20_deprecated.py— missingnitrostack.transports.dispatchtest_mcp20_jsonrpc_wire.py— missingnitrostack.transports.dispatchtest_mcp20_stateless_http.py— cannot importbuild_ping_response
(Additional failed test after removing the above ones)
test_mcp20_test_modules_importabletest_supported_versions_per_era
Please address the remaining test failures and rerun the full test suite.
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #23. Depends on #34; merge #34 first.
Complete the HTTP factory migration after removal of the duplicate JSON-RPC
sidecar. Official MCP 2.x remains the sole owner of
/mcp; NitroStack suppliesthe application handlers, transport configuration, CORS, and era policy.
This update also addresses the review identifying four test-collection errors
and two additional full-suite failures.
Changes
through the official MCP HTTP application. Kept pure parser, header, CORS,
SSE, protocol-contract, and response-echo coverage.
now import successfully; no sidecar compatibility shims were restored.
developnormally. This includes the existingsupported-version expectation fix for
2025-11-25; no protocol dates or eraaliases were added or removed by this update.
and subscription handlers: legacy compatibility remains enabled;
autoandmodernadvertise false and reject subscribe/unsubscribe requests.server instances and stdio capability negotiation.
Server.middlewareon already-parsed request contexts. No JSON-RPC body parsing, buffering, or
response generation was added to ASGI middleware. Compatible headerless
requests retain the SDK's implicit legacy fallback.
era-driven
/json/version, session-manager selection, health/slash handling,and public stdio runner APIs.
legacy initialization, notifications, and initialization rejection.
Verification
MCP version tested: 2.2.0.
Hosted CI: all checks passed
Python SDK Test Suite run 40511981383
completed successfully on final head
71e47f1:No skipped tests, xfails, ignored files, or deselections were used.
Local cross-platform verification
These are complete runs with no ignored files, deselections, skips, or xfails.
Two pre-existing pure utility checks were subsequently restored and passed
separately on all four runtimes. Final collection is 809 tests, with no
collection errors; the completed hosted matrix above ran all 809 together.
utility checks were restored.
76 passed.
git diff --checkpassed.See
docs/pr36-review-verification.mdfor baseline commit IDs, the migrationmap, exact validation results, and the distinction between the local Linux
matrix and hosted CI status.