Repository navigation
fix(editor): match core rows and drop top-bar breakpoints - #292
Merged
Merged
Conversation
- Effect row groups take the block editor's color-row border (#ddd) and radius, and the toggle reports aria-expanded like core. - The Pro note in the Effects panel keeps the ToolsPanel 16px gap below an added Reveal row. - The icon pack filter sizes each option to its label. - Ghost Kit breakpoints leave the View menu and the WordPress 6.6 toolbar. Block control toggles still preview the breakpoint, and a core device still turns that preview off.
isAdaptiveWidth inside a full-width group left an empty strip at the end; without isBlock the group is as wide as its options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the editor UI review on WordPress 7.2-beta1. Each value below was measured with
getComputedStylein a live 7.2-beta1 editor against the core row it copies.Effect rows. The grouped rows (the Transition row in the Reveal popover, and Pro's effect popovers, which use the same component) had a lighter border than core:
rgba(0,0,0,.1)against core's#dddon.block-editor-color-gradient-item. They now use#ddd, the first and last rows get core's 2px corner radius, and the toggle setsaria-expandedlike core's row button. Row height (40px), padding, hover color, open background (#f0f0f0, theme color text) and the keyboard focus outline (1px theme color) already matched and are unchanged.rgb(221,221,221)rgba(0,0,0,.1)rgb(221,221,221)aria-expandedwhen opentruetruePro note spacing. The Effects panel stacks its rows in one grid cell without the ToolsPanel gap, so the "Advanced effects are available in Ghost Kit Pro" line sat flush under an added Reveal row. It now gets the ToolsPanel row gap (16px) when something is above it.
Icon pack filter. The toggle group uses the public
isAdaptiveWidthprop, so each option is as wide as its label (All 40px, Ghost Kit 80px, FontAwesome 109px instead of 95px each).Breakpoints leave the top bar. Ghost Kit no longer adds its breakpoints to the View menu, and the WordPress 6.6 toolbar switcher is gone, so 6.6 shows core's own preview dropdown again. The per-control responsive toggles in block settings still resize the canvas to the picked breakpoint. The hook that clears the Ghost Kit breakpoint when a core device is picked stays: without it, picking Tablet after a Mobile toggle kept the canvas at 375px. The new E2E test fails without that hook (
Expected: "",Received: "sm").Checked locally on 7.2-beta1 and 6.6.2: lint, PHPUnit (92 tests), build, and the responsive-switcher, effects and icon-picker E2E specs. On 6.6.2 one icon-picker test ("picks an icon with the keyboard and closes with Escape") fails at the Escape-clears-search step with and without this change. CI does not run E2E on 6.6.