Repository navigation
fix(activate): upgrade the database before activating - #4
Merged
Merged
Conversation
After a switch of the WordPress core version, wp-admin redirects to upgrade.php until the database is upgraded, and the E2E setup's requestUtils.activateTheme fails with "The theme ... is not installed". wp core update-db is a no-op on a current database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a wp-env's WordPress core version is switched (for example 7.1 to 7.2-beta1), the database stays at the old version. wp-admin then redirects to
upgrade.php, and the E2E global setup'srequestUtils.activateThemefails with "The theme ... is not installed".nk-activate-pluginsnow runswp core update-db --quietin each container before activating plugins. On a current database it does nothing. A failed upgrade counts as a failed attempt, so the existing retry loop covers a site that is still coming up.The self-test runs the script against a fake
wp-envand checks the call order in both sites. The check fails on the previous script, which never calledupdate-db.Scripted proof on ghostkit (start on 7.1, switch core to 7.2-beta1 via
.wp-env.override.json, restart):Publishing a new version and bumping it in the plugins is a separate step.