Skip to content

feat: add setPerpAnnotation perpDeploy action and perpAnnotation info endpoint#122

Merged
nktkas merged 4 commits into
nktkas:mainfrom
metro-xyz:setPerpAnnotation-perpDeploy-variant
Mar 1, 2026
Merged

feat: add setPerpAnnotation perpDeploy action and perpAnnotation info endpoint#122
nktkas merged 4 commits into
nktkas:mainfrom
metro-xyz:setPerpAnnotation-perpDeploy-variant

Conversation

@damjankuznar

@damjankuznar damjankuznar commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Closes #121

@damjankuznar

Copy link
Copy Markdown
Contributor Author

@nktkas can we merge this and make a new release - I just got word that HL will require annotations for all HIP-3 perps next week

@nktkas nktkas left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes need to be made, after which this PR can be merged.

P.S. forgot to click the "Submit review" button

Comment thread src/api/info/_methods/perpAnnotation.ts Outdated
Comment thread tests/api/info/perpAnnotation.test.ts Outdated

@nktkas nktkas left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the code needs to be updated to the latest commit.

Comment thread src/api/info/_methods/perpAnnotation.ts
Comment thread src/api/info/_methods/perpAnnotation.ts
Comment thread src/api/info/_methods/perpAnnotation.ts Outdated
Comment thread src/api/info/_methods/perpAnnotation.ts Outdated
Comment thread src/api/info/client.ts Outdated
Comment thread src/api/info/client.ts Outdated
Comment thread tests/api/info/perpAnnotation.test.ts Outdated
@nktkas

nktkas commented Feb 28, 2026

Copy link
Copy Markdown
Owner

@damjankuznar after these changes are accepted, this PR can be merged and I will immediately release a new version

@damjankuznar damjankuznar force-pushed the setPerpAnnotation-perpDeploy-variant branch from 7235939 to 5b98a41 Compare March 1, 2026 20:23
damjankuznar and others added 3 commits March 1, 2026 21:26
Co-authored-by: nktkas <github.turk9@passmail.net>
Signed-off-by: Damjan Kužnar <damjan.kuznar@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: nktkas <github.turk9@passmail.net>
Signed-off-by: Damjan Kužnar <damjan.kuznar@gmail.com>
@damjankuznar

Copy link
Copy Markdown
Contributor Author

@nktkas is this ok now?

@nktkas

nktkas commented Mar 1, 2026

Copy link
Copy Markdown
Owner

Yes, now it looks good.
Thanks for your contribution!!!

@nktkas nktkas merged commit 332c024 into nktkas:main Mar 1, 2026
1 check passed
@damjankuznar damjankuznar deleted the setPerpAnnotation-perpDeploy-variant branch March 24, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing setPerpAnnotation perpDeploy action

2 participants