Fix large decimal price formatting#134
Closed
samsamtrum wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the PR, but this doesn't change anything in practice:
Closing — no reachable behavior change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes precision loss when formatting very large decimal strings.
StringMath.log10Floor()currently converts the integer portion throughNumber(...)to decide whether the value is >= 1. For very large decimal strings this loses arbitrary-precision behavior and can also overflow toInfinity, while the rest of the formatter is string-based.This derives the magnitude directly from string digits instead, and adds a regression test for a large decimal price.
I could not run the Deno test locally because
denois not installed in my environment.