Skip to content

fix(docs): fix sidebar scrollIntoView selecting last item erroneously #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Botato300 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(docs): fix sidebar scrollIntoView selecting last item erroneously #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/generators/legacy-html/assets/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,18 +203,19 @@ const setupCopyButton = () => {
function setupSidebarScroll() {
const sidebarLinks = document.querySelectorAll('#column2 a');

let link;
for (link of sidebarLinks) {
let activeLink = null;
for (const link of sidebarLinks) {
if (link.pathname === window.location.pathname) {
activeLink = link;
break;
}
}

if (!link) {
if (!activeLink) {
return;
Comment on lines +206 to 215
Copy link
Copy Markdown
Member

@avivkeller avivkeller Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a .find?

Copy link
Copy Markdown
Author

@Botato300 Botato300 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use .find(), you first need to convert sidebarLinks into an array (using Array.from()). I can simplify this, would you like me to do that?

Copy link
Copy Markdown
Member

@avivkeller avivkeller Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, opinions @nodejs/web-infra?

}

link.scrollIntoView({ behavior: 'smooth', block: 'center' });
activeLink.scrollIntoView({ behavior: 'smooth', block: 'center' });
}

// Initialize either on DOMContentLoaded or immediately if already loaded
Expand Down
Loading