Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Port all three build targets and test files from upstream: - myobject (stable) — object wrap with getters/setters/methods - myobject_basic_finalizer (experimental) — basic finalizer verification - nested_wrap (NAPI_VERSION=10) — nested ref finalization The experimental target (myobject_basic_finalizer) exercises the add_node_api_cts_experimental_addon() CMake function for the first time, serving as end-to-end validation of the experimental infrastructure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kraenhansen
force-pushed
the
feat/port-6-object-wrap
branch
from
d57e9e9 to
d833299
Compare
Contributor
Author
|
CI fails on Node.js v20 — same root cause as #28. The Blocked on #37 (dropping Node v20 from CI). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
6_object_wrapfrom the Node.js test suite into the CTS. This is the first test to exercise the experimental addon infrastructure (add_node_api_cts_experimental_addon()), serving as end-to-end validation of #31.Three build targets:
myobject(stable) — object wrap with getters/setters,plusOne,multiplymyobject_basic_finalizer(experimental,NAPI_EXPERIMENTAL) — basic finalizer verification, guarded byexperimentalFeatures.postFinalizernested_wrap(NAPI_VERSION=10) — nested napi_ref finalizationThree JS test files:
test.js— property descriptors, constructor/plain-function invocation, method chainingtest-basic-finalizer.js— experimental finalizer withgcUntil, behind feature guardnested_wrap.js— nested wrap finalization withgcUntilAll C++ source files are copied verbatim from upstream.
Test plan
npm run addons:configure && npm run addons:build— all three targets compilenpm run node:test— all 58 tests pass (3 new)🤖 Generated with Claude Code