Skip to content

lib: fix typos in esm loader comments#63465

Open
RonGamzu wants to merge 1 commit into
nodejs:mainfrom
RonGamzu:fix/typo-esm-loader-comments
Open

lib: fix typos in esm loader comments#63465
RonGamzu wants to merge 1 commit into
nodejs:mainfrom
RonGamzu:fix/typo-esm-loader-comments

Conversation

@RonGamzu
Copy link
Copy Markdown

Fixes three typos in comments in the importSyncForRequire path of
lib/internal/modules/esm/loader.js:

  • "check the whether" β†’ "check whether"
  • "kEvaluaing" β†’ "kEvaluating" (matches the symbol used elsewhere in
    the file, e.g. the import on line 53 and the comparisons on lines
    340 and 382)
  • "the the problematic" β†’ "the problematic"

Comment-only change; no functional impact.

Three typos in comments in the importSyncForRequire path:

- "check the whether" -> "check whether"
- "kEvaluaing" -> "kEvaluating" (matches the symbol used elsewhere
  in the file)
- "the the problematic" -> "the problematic"

No functional change.

Signed-off-by: RonGamzu <37371774+RonGamzu@users.noreply.github.com>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 20, 2026
@aduh95 aduh95 added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please πŸ‘ to approve.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.06%. Comparing base (b5659d1) to head (5a8a369).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63465   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         714      714           
  Lines      225918   225918           
  Branches    42729    42736    +7     
=======================================
+ Hits       203466   203468    +2     
+ Misses      14231    14224    -7     
- Partials     8221     8226    +5     
Files with missing lines Coverage Ξ”
lib/internal/modules/esm/loader.js 99.71% <100.00%> (ΓΈ)

... and 25 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants