stream: flush each fused stateless transform#63468
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Ensure consecutive stateless stream/iter transforms each receive a final null flush after upstream flush output has been processed. Fixes: nodejs#63467 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-consecutive-text
branch
from
97055b3 to
1cef78f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63468 +/- ##
==========================================
- Coverage 91.67% 90.09% -1.59%
==========================================
Files 361 714 +353
Lines 156408 225935 +69527
Branches 24050 42743 +18693
==========================================
+ Hits 143384 203550 +60166
- Misses 12751 14169 +1418
- Partials 273 8216 +7943
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes fused stateless
stream/itertransform flushing so eachtransform receives its own final
nullafter upstream flush output hasbeen processed.
Previously, if one stateless transform emitted data during flush, the
next transform processed that data but did not receive its own final
flush signal.
Fixes: #63467
Assisted-by: openai:gpt-5.5