Skip to content

[canary-base] test: remove test-node-output-v8-warning#63469

Open
joyeecheung wants to merge 1 commit into
nodejs:canary-basefrom
joyeecheung:remove-v8-warning
Open

[canary-base] test: remove test-node-output-v8-warning#63469
joyeecheung wants to merge 1 commit into
nodejs:canary-basefrom
joyeecheung:remove-v8-warning

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented May 21, 2026

asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for v8::Isolate::kMessageWarning. Remove the test.

Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Fixes: nodejs/node-v8#310

asm.js validation is deprecated and disabled by default in V8,
so there's no longer a stable user-reachable trigger for
`v8::Isolate::kMessageWarning`. Remove the test.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 21, 2026
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented May 21, 2026

Failed tests:
out/Release/node --expose-internals /Users/runner/work/node/node/node/test/parallel/test-v8-serdes.js
out/Release/node /Users/runner/work/node/node/node/test/parallel/test-worker-stack-overflow-stack-size.js
out/Release/node --experimental-wasm-modules /Users/runner/work/node/node/node/test/wpt/test-wasm-jsapi.mjs

@joyeecheung
Copy link
Copy Markdown
Member Author

The failures are pre-existing, canary base is usually broken to some extent currently

@joyeecheung
Copy link
Copy Markdown
Member Author

I plan to land this once this passes the 48h mark, I don't think canary-base is subject to main/release rules, though it's not a huge deal to wait for two more days to see if anyone objects to removing these tests (the commit should be reviewed again in the big V8 upgrade PR before going into main through). Obviously "CI should be green" rules doesn't apply to a branch that's constantly broken and not even tested as-is but with V8 lkgr on top every day 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants