ffi: validate 'void' as parameter type in getFunction and getFunctions by Anshikakalpana · Pull Request #63504 · nodejs/node

Anshikakalpana · 2026-05-23T09:00:33Z

Passing 'void' as a parameter type in getFunction or getFunctions triggers an internal assertion instead of a user-friendly error.

In C, void in a parameter list means a function takes no arguments, expressed in Node.js FFI as an empty array []. There is no valid use case for 'void' as a parameter type.

Fix:
add early validation in getFunction and getFunctions that throws ERR_INVALID_ARG_VALUE when 'void' appears in the parameters array, before wrapWithSharedBuffer is called.

ShogunPanda · 2026-05-23T09:28:16Z

No, this is wrong. Don't validate at JS level but within C++ level please.

Anshikakalpana · 2026-05-23T10:21:57Z

No, this is wrong. Don't validate at JS level but within C++ level please.

Moved validation into the native FFI signature parsing layer in src/ffi/types.cc as suggested. Also removed the temporary JS-side validation.

ShogunPanda

LGTM!

nodejs-github-bot · 2026-05-23T11:05:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73625/

codecov · 2026-05-23T12:34:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (2e3daf6) to head (401f456).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #63504    +/-   ##
========================================
  Coverage   90.34%   90.34%            
========================================
  Files         730      730            
  Lines      234359   234468   +109     
  Branches    43923    43911    -12     
========================================
+ Hits       211720   211823   +103     
- Misses      14361    14373    +12     
+ Partials     8278     8272     -6

Files with missing lines	Coverage Δ
src/ffi/types.cc	`47.51% <100.00%> (+0.60%)`	⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ShogunPanda · 2026-05-24T04:57:55Z

CI failures are relevant

Anshikakalpana · 2026-05-24T05:39:26Z

CI failures are relevant

Hi @ShogunPanda, the Jenkins failures are from the old commit 06410ff (confirmed via COMMIT_SHA_CHECK in the job parameters). GitHub Actions on the current commit 618bed6 are fully green. Could you please trigger a fresh CI run?

nodejs-github-bot · 2026-05-24T07:26:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73650/

Anshikakalpana · 2026-05-24T12:08:58Z

Fixed the Windows failure — DynamicLibrary(null) rejects null on Windows. Now using kernel32.dll on Windows and null on Unix. Sorry for the multiple runs!

nodejs-github-bot · 2026-05-24T12:37:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73656/

nodejs-github-bot · 2026-05-25T04:12:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73688/

ShogunPanda · 2026-05-25T05:06:23Z

@Anshikakalpana unfortunately the failure still seems relevant. Can you please take a look?

nodejs-github-bot · 2026-05-25T09:49:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73701/

ShogunPanda · 2026-05-25T11:04:25Z

Still failing :(

Anshikakalpana · 2026-05-25T11:18:48Z

Update: found the issue — assert.throws with a regex matches against the error message, not the code. Fixed both assertions to use { code: 'ERR_INVALID_ARG_VALUE' }. Latest push should be green.

nodejs-github-bot · 2026-05-25T13:45:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73709/

ShogunPanda · 2026-05-25T17:31:21Z

@Anshikakalpana Now is the linter 😭

Fixes: nodejs#63461 Signed-off-by: Anshikakalpana <anshikajain196872@gmail.com>

Anshikakalpana · 2026-05-25T19:05:48Z

Sorry! Trailing space on the blank line — fixed now.

nodejs-github-bot · 2026-05-25T19:17:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73721/

nodejs-github-bot · 2026-05-26T20:10:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73757/

nodejs-github-bot · 2026-05-27T06:43:58Z

Commit Queue failed

- Loading data for nodejs/node/pull/63504
✔  Done loading data for nodejs/node/pull/63504
----------------------------------- PR info ------------------------------------
Title      ffi: validate 'void' as parameter type in getFunction and getFunctions (#63504)
Author     Anshika Jain <anshikajain196872@gmail.com> (@Anshikakalpana)
Branch     Anshikakalpana:ffi-void-parameter -> nodejs:main
Labels     needs-ci, ffi
Commits    1
 - ffi: validate 'void' as parameter type in getFunction and getFunctions
Committers 1
 - anshikakalpana <anshikajain196872@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63504
Fixes: https://github.com/nodejs/node/issues/63461
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63504
Fixes: https://github.com/nodejs/node/issues/63461
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 23 May 2026 09:00:33 GMT
   ✔  Approvals: 1
   ✔  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/63504#pullrequestreview-4358414426
   ✘  This PR needs to wait 75 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-26T20:10:13Z: https://ci.nodejs.org/job/node-test-pull-request/73757/
- Querying data for job/node-test-pull-request/73757/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/26495351583

mcollina

lgtm

nodejs-github-bot · 2026-05-27T08:13:46Z

Landed in 31c40f0

nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 23, 2026

Anshikakalpana force-pushed the ffi-void-parameter branch from 8b78e7a to 58e5f70 Compare May 23, 2026 09:08

Anshikakalpana mentioned this pull request May 23, 2026

ffi: 'void' as parameter type triggers internal assertion #63461

Closed

Anshikakalpana force-pushed the ffi-void-parameter branch 2 times, most recently from 455f25e to 06410ff Compare May 23, 2026 10:19

ShogunPanda approved these changes May 23, 2026

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2026

Anshikakalpana force-pushed the ffi-void-parameter branch from 06410ff to 618bed6 Compare May 23, 2026 11:12

ShogunPanda approved these changes May 24, 2026

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026

Anshikakalpana force-pushed the ffi-void-parameter branch from 618bed6 to 43c1eb8 Compare May 24, 2026 10:36

ShogunPanda approved these changes May 24, 2026

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2026

Anshikakalpana force-pushed the ffi-void-parameter branch 2 times, most recently from a28da0d to 5683e58 Compare May 25, 2026 07:42

ShogunPanda approved these changes May 25, 2026

View reviewed changes

Anshikakalpana force-pushed the ffi-void-parameter branch from 5683e58 to 78160bf Compare May 25, 2026 11:13

ShogunPanda approved these changes May 25, 2026

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2026

ffi: validate 'void' as parameter type in getFunction and getFunctions

401f456

Fixes: nodejs#63461 Signed-off-by: Anshikakalpana <anshikajain196872@gmail.com>

Anshikakalpana force-pushed the ffi-void-parameter branch from 78160bf to 401f456 Compare May 25, 2026 19:03

ShogunPanda approved these changes May 25, 2026

View reviewed changes

ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2026

ShogunPanda added ffi Issues and PRs related to experimental Foreign Function Interface support. commit-queue Add this label to land a pull request using GitHub Actions. labels May 27, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 27, 2026

mcollina approved these changes May 27, 2026

View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 27, 2026

nodejs-github-bot merged commit 31c40f0 into nodejs:main May 27, 2026
89 checks passed

Uh oh!

Conversation

Anshikakalpana commented May 23, 2026

Uh oh!

ShogunPanda commented May 23, 2026

Uh oh!

Anshikakalpana commented May 23, 2026

Uh oh!

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 23, 2026

Uh oh!

codecov Bot commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShogunPanda commented May 24, 2026

Uh oh!

Anshikakalpana commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented May 24, 2026

Uh oh!

Anshikakalpana commented May 24, 2026

Uh oh!

nodejs-github-bot commented May 24, 2026

Uh oh!

nodejs-github-bot commented May 25, 2026

Uh oh!

ShogunPanda commented May 25, 2026

Uh oh!

nodejs-github-bot commented May 25, 2026

Uh oh!

ShogunPanda commented May 25, 2026

Uh oh!

Anshikakalpana commented May 25, 2026

Uh oh!

nodejs-github-bot commented May 25, 2026

Uh oh!

ShogunPanda commented May 25, 2026

Uh oh!

Anshikakalpana commented May 25, 2026

Uh oh!

nodejs-github-bot commented May 25, 2026

Uh oh!

nodejs-github-bot commented May 26, 2026

Uh oh!

nodejs-github-bot commented May 27, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 23, 2026 •

edited

Loading

Anshikakalpana commented May 24, 2026 •

edited

Loading