stream: prefer sync iterator in fromSync#64294
Merged
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
reviewed
Jul 5, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
force-pushed
the
stream-iter-fromsync-iter
branch
from
1e713e7 to
f21d604
Compare
jasnell
approved these changes
Jul 7, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
When an input provides Symbol.iterator, fromSync() should consume the synchronous iterator instead of rejecting the input because it also exposes an asynchronous or promise-like protocol. Continue rejecting async-only iterables and promise/thenable-only inputs, but allow sync iterables that also define Symbol.asyncIterator or then(). Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-fromsync-iter
branch
from
f21d604 to
ce6448e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jul 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64294 +/- ##
==========================================
+ Coverage 90.23% 90.25% +0.01%
==========================================
Files 741 741
Lines 240979 240984 +5
Branches 45401 45409 +8
==========================================
+ Hits 217449 217500 +51
+ Misses 15112 15068 -44
+ Partials 8418 8416 -2
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 91b65a4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64292
stream/iter'sfromSync()rejected any input that exposedSymbol.asyncIterator, even when the same input also exposedSymbol.iterator.This updates
fromSync()to reject only inputs without a synchronousiteration path, allowing dual sync/async iterables and thenable sync
iterables to be consumed through their synchronous iterator.
Assisted-by: openai:gpt-5.5