Skip to content

Revert "tools: add --error-on-warn configure flag in test-shared.yml" - #66923

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:revert-66751
Closed

panva wants to merge 1 commit into
nodejs:mainfrom
panva:revert-66751

Conversation

@panva

@panva panva commented Oct 22, 2026

Copy link
Copy Markdown
Member

This reverts commit a232998.


Tnd test-shared.yml workflow is unhappy on main and in PRs following the --error-on-warn from #66751.

https://github.com/nodejs/node/actions/runs/39746750476/job/119717618436
https://github.com/nodejs/node/actions/runs/39761975718/job/119768615488?pr=66922

@panva panva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 22, 2026
@panva

panva commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

Preferred alternative in #66925

@panva panva closed this Oct 22, 2026
@panva
panva deleted the revert-66751 branch October 22, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants