Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.10',
'v8_embedder_string': '-node.11',

##### V8 defaults for Node.js #####

Expand Down Expand Up @@ -588,6 +588,13 @@
'_HAS_EXCEPTIONS=0',
'BUILDING_V8_SHARED=1',
'BUILDING_UV_SHARED=1',
# Node.js is built with clang-cl but native addons may be built
# with MSVC, which does not support preserve_most.
# As preserve_most changes the mangled name of a function in the
# Microsoft C++ ABI, the addons would fail to link against the
# exported symbols. So this define must be consistely set for
# both the V8 build and addon builds.
'V8_DISABLE_PRESERVE_MOST',
# Stop <windows.h> from defining macros that conflict with
# std::min() and std::max(). We don't use <windows.h> (much)
# but we still inherit it from uv.h.
Expand Down
1 change: 1 addition & 0 deletions deps/v8/include/v8config.h
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,7 @@ path. Add it with -I<path> to the command line
|| ((defined(__AARCH64EL__) || defined(_M_ARM64)) /* arm64, but ... */ \
&& !defined(_WIN32))) /* not on windows */ \
&& !defined(COMPONENT_BUILD) /* no component build */\
&& !defined(V8_DISABLE_PRESERVE_MOST) /* embedder opt-out */ \
&& __clang_major__ >= 17 /* clang >= 17 */
# define V8_HAS_ATTRIBUTE_PRESERVE_MOST (__has_attribute(preserve_most))
#endif
Expand Down
Loading