fix: Incorrect function type breaking arg length and generators#70
Merged
Conversation
3 tasks
timfish
approved these changes
Apr 29, 2026
jsumners-nr
reviewed
Apr 29, 2026
| // The arrow function doesn't bind its own `arguments`, so `arguments.length` | ||
| // inside it refers to the constructor's argument count (2), not the call-site | ||
| // count (1). The regular function binds its own `arguments`, so it sees the | ||
| // call-site count (1). Instrumentation must not change either binding. |
Contributor
There was a problem hiding this comment.
Isn't the count 3?
I see that the 1 is from the test.js usage of the methods. Definitely confusing without knowing what the test file looks like.
jsumners-nr
approved these changes
Apr 29, 2026
timfish
changed the title
bizob2828
pushed a commit
to bizob2828/orchestrion-js
that referenced
this pull request
Apr 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.