Skip to content

refactor the skills to reduce tokens and improve progresive disclousure patterns#47

Closed
Cesar-M-Diaz wants to merge 0 commit into
cesar/github-install-testfrom
cesar/skills-refactor
Closed

refactor the skills to reduce tokens and improve progresive disclousure patterns#47
Cesar-M-Diaz wants to merge 0 commit into
cesar/github-install-testfrom
cesar/skills-refactor

Conversation

@Cesar-M-Diaz

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a339f4d-cb7d-4a4d-b7ca-410df2d38bd0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@dobleuber dobleuber left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have a conflict in the skills instructions

Comment on lines +43 to +44
- CPU profile: `node "<skill-dir>/wait.cjs" 35`.
- Heap sample: `node "<skill-dir>/wait.cjs" 30`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new wait step instructs agents to run node "<skill-dir>/wait.cjs" for CPU/heap asset generation, but this same skill still says to “Use ONLY N|Solid MCP tools” and “Do not use shell commands or bundled helper scripts for waits or downloads” in the guardrails. In practice, an agent following the stricter guardrail can refuse the required wait step, while an agent following step 4 violates the guardrail; this makes CPU/heap asset capture workflows unreliable. Please update the guardrails to allow the bundled wait helper, or switch the wait step back to the intended MCP wait tool.

Comment thread skills/ns-benchmark-run/SKILL.md Outdated
@Cesar-M-Diaz Cesar-M-Diaz force-pushed the cesar/skills-refactor branch from 583b49a to b431bb5 Compare June 29, 2026 15:17

@jdaison jdaison left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cesar-M-Diaz Cesar-M-Diaz force-pushed the cesar/skills-refactor branch from b431bb5 to b481c92 Compare June 30, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants