Skip to content

remove staging flag, unnecesary docs and improve readme#48

Merged
Cesar-M-Diaz merged 4 commits into
mainfrom
cesar/commands-cleanup
Jul 7, 2026
Merged

remove staging flag, unnecesary docs and improve readme#48
Cesar-M-Diaz merged 4 commits into
mainfrom
cesar/commands-cleanup

Conversation

@Cesar-M-Diaz

@Cesar-M-Diaz Cesar-M-Diaz commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added --accounts-url CLI option and documented an install verification workflow using nsolid-plugin doctor --harness <harness>.
    • Refreshed OpenCode’s documented two-step flow: authentication via setup, then skills/MCP configuration via install.
  • Bug Fixes
    • Updated NodeSource URL handling to follow non-staging SaaS rules for accounts and console→MCP derivation.
  • Documentation
    • Expanded harness-specific install/auth sequencing (including OpenCode command order, install destinations, and collision avoidance), updated Antigravity/Pi guidance, and deleted the outdated QA guide.
  • Tests/Chores
    • Updated authentication, CLI help, installer, and asset-sync integration tests; improved core skill materialization cleanup and drift checks.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 020d0bdb-f4b7-44bc-9b97-832a17dc2079

📥 Commits

Reviewing files that changed from the base of the PR and between cef0515 and ace2ec3.

📒 Files selected for processing (1)
  • packages/core/test/integration/plugin-assets.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/core/test/integration/plugin-assets.test.ts

Walkthrough

This PR removes staging-specific CLI and URL handling, switches setup to --accounts-url, updates OpenCode to a setup-then-install flow, and adds cleanup for materialized core skills plus version bumps.

Changes

Staging removal and OpenCode flow updates

Layer / File(s) Summary
Core URL resolution
packages/core/src/index.ts, packages/core/src/auth/token-validator.ts, packages/core/src/auth/mcp-url.ts, packages/core/src/types.ts, packages/core/test/integration/auth/*, packages/core/test/unit/auth/token-validator.test.ts, scripts/mcp-wrapper.js
Removed staging-specific accounts URL logic and hostname rewriting; resolution now uses NSOLID_ACCOUNTS_URL and .saas.nodesource.io mapping, with auth tests updated to match and wrapper derivation aligned.
CLI flags and harness help
packages/core/src/cli.ts, packages/core/test/integration/cli-help.test.ts, scripts/materialize-github-marketplace.mjs, scripts/plugin-generators.mjs
Replaced --staging with --accounts-url, updated setup wiring and help text, and changed generated setup command strings for the supported harness set.
Docs for OpenCode and install flow
README.md, packages/core/README.md, packages/pi-plugin/README.md, docs/antigravity-research.md
Reworked README and package docs for OpenCode’s setup then install flow, revised archived Antigravity notes, and removed staging references from setup instructions.
Core skills cleanup and release metadata
scripts/sync-plugin-assets.mjs, packages/core/test/integration/plugin-assets.test.ts, packages/core/package.json, packages/pi-plugin/package.json
Added cleanup and drift detection for packages/core/skills, covered it with an integration test, and bumped package versions to 1.0.0.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers: edsadr, dobleuber

Poem

I hopped through docs with twitchy nose,
Where staging paths once went and froze.
Now setup greets, install takes care,
And OpenCode feels clean andేర్? 🐇
Thump, thump—fresh carrots in the air!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main themes: removing the staging flag, cleaning up docs, and updating README guidance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/antigravity-research.md`:
- Line 3: The amendment in antigravity-research.md says the old
scripts/install.js flow is superseded, but the document still presents it as
active guidance. Update the markdown around the amendment and the install
walkthrough so readers clearly see it is archival, or remove the obsolete
install.js instructions entirely. Use the document title/intro and the
“Amendment (2026-06-24)” section to locate the affected text and keep the
guidance consistent.

In `@README.md`:
- Around line 87-104: The no-global-install path is only shown for setup, but
the OpenCode flow then requires nsolid-plugin install, which may not be
available without a global install. Update the README’s setup/install guidance
to either include the npx form for both setup and install, or explicitly state
that the two-step OpenCode flow requires the global nsolid-plugin command on
PATH. Reference the setup and install CLI examples in the direct CLI install
section so the install path stays consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8f7a9ebb-98af-4a89-b6ec-445bc2616a62

📥 Commits

Reviewing files that changed from the base of the PR and between 5249f64 and 97ba374.

📒 Files selected for processing (18)
  • README.md
  • docs/antigravity-research.md
  • docs/qa-guide.md
  • packages/core/README.md
  • packages/core/src/auth/mcp-url.ts
  • packages/core/src/auth/token-validator.ts
  • packages/core/src/cli.ts
  • packages/core/src/index.ts
  • packages/core/src/types.ts
  • packages/core/test/integration/auth/accounts-url-override.test.ts
  • packages/core/test/integration/auth/auth-manager.test.ts
  • packages/core/test/integration/cli-help.test.ts
  • packages/core/test/integration/installer.test.ts
  • packages/core/test/unit/auth/token-validator.test.ts
  • packages/pi-plugin/README.md
  • scripts/materialize-github-marketplace.mjs
  • scripts/mcp-wrapper.js
  • scripts/plugin-generators.mjs
💤 Files with no reviewable changes (3)
  • docs/qa-guide.md
  • packages/core/src/auth/token-validator.ts
  • packages/core/test/integration/auth/auth-manager.test.ts

Comment thread docs/antigravity-research.md Outdated
Comment thread README.md Outdated
@Cesar-M-Diaz Cesar-M-Diaz force-pushed the cesar/commands-cleanup branch from 97ba374 to 3f0d370 Compare July 7, 2026 17:14
@Cesar-M-Diaz Cesar-M-Diaz merged commit ace2ec3 into main Jul 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants