Skip to content

Commit 5b12fc8

Browse files
authored
Merge pull request #127 from nodezoo/coverallssearch
Coveralls in search page
2 parents 43c5b35 + a27dc39 commit 5b12fc8

5 files changed

Lines changed: 18 additions & 9 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
* Coveralls integration
1+
* Integrated Coveralls on search and info pages
22
* Set Up Mocha and Instabul
33

44
## 11 April 2016 - 6.1.0

client/assets/css/components/module.styl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@
7171
&.passed
7272
background-color: #56A93C
7373

74+
.img-badge
75+
height: 24px
76+
width: auto
77+
padding: 1px 0
78+
7479
#query-results-container
7580
&.panel
7681
padding: $ui-spacing-half

client/components/module-source.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
'use strict'
22

33
import React from 'react'
4+
import classNames from 'classnames'
45

56
export const ModuleSource = React.createClass({
67
propTypes: {
78
data: React.PropTypes.object.isRequired,
8-
sourceName: React.PropTypes.string.isRequired
9+
sourceName: React.PropTypes.string.isRequired,
10+
imgSrc: React.PropTypes.string
911
},
1012
render () {
11-
let className = `logo logo-${this.props.sourceName} ${this.props.className}`
12-
let source = this.props.data[this.props.sourceName]
13-
let url = source ? source.url : ''
13+
let {imgSrc, sourceName, className, data: {[sourceName]: source}, data: {[sourceName]: {url: url}}} = this.props
14+
let logoClass = classNames({[`logo logo-${sourceName} ${className}`]: !imgSrc})
15+
let img = imgSrc && <img src={imgSrc} alt={sourceName} className="img-badge"/>
1416

1517
return (
16-
source && source.connected
17-
? <a href={url} target='_blank' className={className} target="_blank"></a>
18-
: null
18+
source && source.connected && <a href={url} target='_blank' target="_blank" className={logoClass}>{img}</a>
1919
)
2020
}
2121
})

client/components/search-result.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ export const SearchResult = React.createClass({
3131
<ModuleSource data={result} sourceName="npm"/>
3232
{this.hasBuild(result.travis) ? null :
3333
<ModuleSource data={result} sourceName="travis"/>}
34+
{result.coveralls && result.coveralls.badgeUrl &&
35+
<ModuleSource data={result} sourceName="coveralls" imgSrc={result.coveralls.badgeUrl}/>
36+
}
3437
</div>
3538
</div>
3639
<p className="module-description">

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@
6060
"style-loader": "0.13.x",
6161
"superagent": "1.6.x",
6262
"vidi-metrics": "0.1.0",
63-
"vidi-seneca-metrics": "0.2.0"
63+
"vidi-seneca-metrics": "0.2.0",
64+
"classnames": "2.2.x"
6465
},
6566
"devDependencies": {
6667
"babel-core": "6.4.x",

0 commit comments

Comments
 (0)